Conversation
julianpoy
force-pushed
the
FXA-10981
branch
4 times, most recently
from
e233298 to
144b2a0
Compare
toufali
reviewed
Jun 3, 2025
StaberindeZA
reviewed
Jun 3, 2025
Contributor
There was a problem hiding this comment.
There are some packages/**/package.json that also have nx as a devDependency. Could these also be updated please?
Member
Author
There was a problem hiding this comment.
Updated! Though we really should not have in subpackages...
julianpoy
force-pushed
the
FXA-10981
branch
2 times, most recently
from
e49aad1 to
963ac4f
Compare
david1alvarez
approved these changes
Jun 3, 2025
julianpoy
force-pushed
the
FXA-10981
branch
2 times, most recently
from
f3a31e0 to
9ac2fe9
Compare
toufali
reviewed
Jun 3, 2025
Because: - Nx is on 19 currently and we want to support the new Nx caching features This commit: - Updates Nx from 19 to 21 - Bumps eslint to 8 across all packages and disables some rules that we do not respect - Some resources needed to be bumped since many of the build steps have been cached, but when run without cache they consume more RAM than available - Several version numbers have been consolidated across packages, but not necessarily upgraded outside of Nx itself. Closes FXA-10981
toufali
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
features
This commit:
do not respect
Closes FXA-10981