Skip to content

task(settings): Target sentry tracing to capture metrics for index#18937

Merged
dschom merged 1 commit intomainfrom
improve-sentry-trace-capture
Jun 3, 2025
Merged

task(settings): Target sentry tracing to capture metrics for index#18937
dschom merged 1 commit intomainfrom
improve-sentry-trace-capture

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented May 28, 2025

Because

  • We want to monitor the index page's performance

This pull request

  • Adds the tracesSampler callback to the sentry config
  • Hard codes this callback to only capture traces for '/'

Issue that this pull request solves

Closes: FXA-11723

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

I was able to validate this manually by setting the SENTRY_DSN_CONTENT env, and adding a break point in the tracesSampler callback.

Because:
- We want to monitor the index page's performance

This Commit:
- Adds  the tracesSampler callback to the sentry config
- Hard codes this callback to only capture traces for '/'
@dschom dschom force-pushed the improve-sentry-trace-capture branch from a6472e0 to 53a6078 Compare May 29, 2025 19:34
@dschom dschom marked this pull request as ready for review May 29, 2025 19:37
@dschom dschom requested a review from a team as a code owner May 29, 2025 19:37
Copy link
Contributor

@chenba chenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dschom. Let's try it.

@dschom dschom merged commit 061d2c8 into main Jun 3, 2025
19 checks passed
@dschom dschom deleted the improve-sentry-trace-capture branch June 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants