Skip to content

task(settings): Lazy load pages#18936

Merged
dschom merged 1 commit intomainfrom
lazy-load-pages
Jun 3, 2025
Merged

task(settings): Lazy load pages#18936
dschom merged 1 commit intomainfrom
lazy-load-pages

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented May 28, 2025

Because

  • We want to optimize main bundle size

This pull request

  • Lazy loads pages, i.e. users will download page templates and code when visited, not upfront.

Issue that this pull request solves

Closes: FXA-11794

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner May 28, 2025 23:20
@dschom dschom force-pushed the lazy-load-pages branch 2 times, most recently from ff39b07 to 94891ae Compare May 29, 2025 01:07
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its working!

Screenshot 2025-05-29 at 6 04 44 PM

Because:
- We want to optimize main bundle size

This Commit:
- Lazy loads pages, ie users will download page templates and code when visited, not upfront.
@dschom dschom force-pushed the lazy-load-pages branch from 94891ae to 3d77803 Compare June 3, 2025 00:42
@dschom dschom merged commit c53bef0 into main Jun 3, 2025
19 checks passed
@dschom dschom deleted the lazy-load-pages branch June 3, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants