fix(payments-next): SP3 invalid coupon code not localized#18932
Merged
elizabeth-ilina merged 1 commit intomainfrom May 30, 2025
Merged
fix(payments-next): SP3 invalid coupon code not localized#18932elizabeth-ilina merged 1 commit intomainfrom
elizabeth-ilina merged 1 commit intomainfrom
Conversation
xlisachan
reviewed
May 29, 2025
elizabeth-ilina
force-pushed
the
FXA-11758-invalid-coupon-code
branch
from
da88fce to
c4f4b38
Compare
elizabeth-ilina
force-pushed
the
FXA-11758-invalid-coupon-code
branch
from
c4f4b38 to
38270f8
Compare
elizabeth-ilina
force-pushed
the
FXA-11758-invalid-coupon-code
branch
from
38270f8 to
13dbe75
Compare
bcolsson
requested changes
May 29, 2025
| next-coupon-error-expired = The code you entered has expired. | ||
| next-coupon-error-generic = An error occurred processing the code. Please try again. | ||
| next-coupon-error-invalid = The code you entered is invalid. | ||
| next-coupon-error-limit-reached = The code you entered has reached its limit. |
Contributor
There was a problem hiding this comment.
Suggested change
| next-coupon-error-limit-reached = The code you entered has reached its limit. | |
| next-coupon-error-limit-reached = The code you entered has reached its limit. | |
| ## |
We should also close the final Group comment as they could potentially apply to unrelated strings during the string extract process.
Contributor
There was a problem hiding this comment.
Ah good to know, thanks for adding the comments!
elizabeth-ilina
force-pushed
the
FXA-11758-invalid-coupon-code
branch
from
13dbe75 to
1527467
Compare
Because: * This commit: * Closes #FXA-11758
elizabeth-ilina
force-pushed
the
FXA-11758-invalid-coupon-code
branch
from
1527467 to
dd593c9
Compare
bcolsson
approved these changes
May 30, 2025
| next-coupon-error-expired = The code you entered has expired. | ||
| next-coupon-error-generic = An error occurred processing the code. Please try again. | ||
| next-coupon-error-invalid = The code you entered is invalid. | ||
| next-coupon-error-limit-reached = The code you entered has reached its limit. |
Contributor
There was a problem hiding this comment.
Ah good to know, thanks for adding the comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-11758
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.