feat(recovery): Add reset password recovery phone views and functionality#18929
feat(recovery): Add reset password recovery phone views and functionality#18929
Conversation
vbudhram
changed the title
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Found a bug while testing locally. Will read through the rest of the code now and follow up with more comments if anything comes up!
| screen.getByRole('link', { | ||
| name: 'Use backup authentication codes instead?', | ||
| }) | ||
| ).toHaveAttribute('href', '/reset_password_recovery_code'); |
There was a problem hiding this comment.
The actual path is /confirm_backup_code_reset_password (should be updated throughout 😄) (Though I do like the idea of having all reset password paths start with reset_password)
There was a problem hiding this comment.
Also noticed that we should make sure that all the paths for 2FA in password reset are listed in content-server, otherwise reloading the urls leads to a Page not found error.
| const FEATURE_FLAGS_RECOVERY_CODE_SETUP_ON_SYNC_SIGN_IN = config.get( | ||
| 'featureFlags.recoveryCodeSetupOnSyncSignIn' | ||
| ); | ||
| const FEATURE_FLAGS_RECOVERY_PHONE_RESET_PASSWORD_2FA = config.get( |
There was a problem hiding this comment.
Should this match the variable name in configuration.js? There it is FEATURE_FLAGS_RECOVERY_PHONE_PASSWORD_RESET_2FA
| @@ -0,0 +1,30 @@ | |||
| ## ResetPasswordRecoveryPhone page | |||
|
|
|||
| reset-password-recovery-phone-flow-heading = Reset your password | |||
There was a problem hiding this comment.
Could use the existing password-reset-flow-heading id for this string, since it's shared across reset password pages.
|
|
||
| await page.waitForURL(/reset_password_totp_recovery_choice/); | ||
|
|
||
| await signinRecoveryChoice.clickChoosePhone(); |
There was a problem hiding this comment.
Should we add these to the resetPassword page model?
3 participants
Because
This pull request
PasswordForgotToken2FA verified upon verifying a recovery phone codeIssue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-11510
Checklist
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.