task: audit yarn resolutions – moment

[toufali]

Because

• Yarn resolutions should be used as last resort
• It doesn't look like this particular resolution does anything

This pull request

• removes the resolution for moment

Issue that this pull request solves

Closes: FXA-11765

Other information (Optional)

I tested before and after resolution removal: all moment dependencies are at 2.30.1 which satisfy the original resolution.

[chenba]

I expect a yarn.lock change. Did removing the resolution have no effect on the actual installed version(s) of moment.js?

[toufali]

I expect a yarn.lock change. Did removing the resolution have no effect on the actual installed version(s) of moment.js?

Correct @chenba – similar to #18926 I think this resolution had been resolved, or the resolution was noop in the first place. Running yarn why moment before the removal satisfied the resolution conditions, just as after removal. Running yarn install has no effect.