fix(settings): make tooltip text start-aligned instead of centered#18923
Merged
MagentaManifold merged 1 commit intomainfrom May 27, 2025
Merged
fix(settings): make tooltip text start-aligned instead of centered#18923MagentaManifold merged 1 commit intomainfrom
MagentaManifold merged 1 commit intomainfrom
Conversation
MagentaManifold
force-pushed
the
FXA-11351
branch
from
4361ba6 to
75ff69d
Compare
MagentaManifold
changed the title
vpomerleau
approved these changes
May 27, 2025
Because: * Error tooltip text is centered and should be RTL or LTR This commit: * makes tooltip text start-aligned instead of centered and adds a story to showcase the multiline scenario. * fixes the bug where a tooltip is limited to have half the width of its parent when anchor position is set to middle. Closes #FXA-11351
MagentaManifold
force-pushed
the
FXA-11351
branch
from
75ff69d to
320ea86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11351
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
LTR:
RTL:
anchor at middle:
Other information (Optional)
Any other information that is important to this pull request.