Skip to content

fix(payments-next):Truncated price in upgrade page#18918

Merged
elizabeth-ilina merged 1 commit intomainfrom
FXA-11648-truncated-price
May 28, 2025
Merged

fix(payments-next):Truncated price in upgrade page#18918
elizabeth-ilina merged 1 commit intomainfrom
FXA-11648-truncated-price

Conversation

@elizabeth-ilina
Copy link
Contributor

@elizabeth-ilina elizabeth-ilina commented May 26, 2025

Because

  • Prorated amount is cut off in certain languages.

This pull request

  • Prevents prorated price from shrinking.

Issue that this pull request solves

Closes: #FXA-11648

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@elizabeth-ilina elizabeth-ilina force-pushed the FXA-11648-truncated-price branch from 40beff1 to cf52232 Compare May 26, 2025 18:22
Because:

* (not done)

This commit:

*

Closes #
@elizabeth-ilina elizabeth-ilina force-pushed the FXA-11648-truncated-price branch from cf52232 to f7d7151 Compare May 26, 2025 18:42
@elizabeth-ilina elizabeth-ilina changed the title fix(payments-next):Truncated price in upgrade pages fix(payments-next):Truncated price in upgrade page May 26, 2025
@elizabeth-ilina elizabeth-ilina marked this pull request as ready for review May 26, 2025 19:19
@elizabeth-ilina elizabeth-ilina requested a review from a team as a code owner May 26, 2025 19:19
Copy link
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Liz!
Screenshot 2025-05-27 at 12 30 14 PM
Screenshot 2025-05-27 at 12 30 42 PM

@elizabeth-ilina elizabeth-ilina merged commit 72df06b into main May 28, 2025
19 checks passed
@elizabeth-ilina elizabeth-ilina deleted the FXA-11648-truncated-price branch May 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants