fix(payments-next): Add localization to page metadata#18910
Merged
elizabeth-ilina merged 1 commit intomainfrom May 28, 2025
Merged
fix(payments-next): Add localization to page metadata#18910elizabeth-ilina merged 1 commit intomainfrom
elizabeth-ilina merged 1 commit intomainfrom
Conversation
elizabeth-ilina
force-pushed
the
FXA-11717-add-localization-to-page-metadata
branch
3 times, most recently
from
fe9a570 to
3fb240c
Compare
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
Changes look good. Mostly just some nit comments that would be good add though if possible.
apps/payments/next/app/[locale]/[offeringId]/[interval]/checkout/[cartId]/start/page.tsx
Outdated
Show resolved
Hide resolved
elizabeth-ilina
force-pushed
the
FXA-11717-add-localization-to-page-metadata
branch
3 times, most recently
from
a51531c to
07a95e0
Compare
elizabeth-ilina
force-pushed
the
FXA-11717-add-localization-to-page-metadata
branch
from
07a95e0 to
b16cd39
Compare
elizabeth-ilina
force-pushed
the
FXA-11717-add-localization-to-page-metadata
branch
2 times, most recently
from
03e133d to
5d7b903
Compare
bcolsson
reviewed
May 28, 2025
elizabeth-ilina
force-pushed
the
FXA-11717-add-localization-to-page-metadata
branch
2 times, most recently
from
d946ebc to
9aa608e
Compare
Because: * This commit: * Closes #FXA-11717
elizabeth-ilina
force-pushed
the
FXA-11717-add-localization-to-page-metadata
branch
from
9aa608e to
a789d68
Compare
david1alvarez
approved these changes
May 28, 2025
Contributor
david1alvarez
left a comment
david1alvarez
left a comment
There was a problem hiding this comment.
This looks good! Nice work
julianpoy
approved these changes
May 28, 2025
bcolsson
approved these changes
May 28, 2025
elizabeth-ilina
added a commit
that referenced
this pull request
May 28, 2025
…page-metadata fix(payments-next): Add localization to page metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-11717
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.