enhance(frontend): remove v-code-diff#17115
Open
kakkokari-gtyih wants to merge 10 commits intomisskey-dev:developfrom
Open
enhance(frontend): remove v-code-diff#17115kakkokari-gtyih wants to merge 10 commits intomisskey-dev:developfrom
kakkokari-gtyih wants to merge 10 commits intomisskey-dev:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17115 +/- ##
============================================
- Coverage 63.52% 13.84% -49.69%
============================================
Files 1161 241 -920
Lines 115939 11664 -104275
Branches 7684 3949 -3735
============================================
- Hits 73655 1615 -72040
+ Misses 40078 7883 -32195
+ Partials 2206 2166 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
MkCodeDiffみたいなコンポーネントを作ってMkCodeを隠蔽する形が奇麗かもしれない Off topic: 設定の変更をJSのDiff形式で提示するのは親切ではなく、ちゃんとした表示を実装するまでの仮の実装だから、将来的にはより分かりやすいUIを実装したい |
Contributor
Author
|
結局ハイライター側(MkCode.core)で直接diffを見てスタイルを適用する都合上、propsを受けて渡すだけのコンポーネントを作ることになるので無駄そう |
Contributor
Author
Related to #16122 (comment) |
Member
|
Diffを表示する箇所は限られるからパフォーマンスは気にする必要はないわね |
Contributor
Author
|
そこで対応を変える意味があるかはあまりよくわからなかったけどとりあえずそうした |
Member
|
Diffを表示する手段はMkCode以外にも現実的に考えられるから隠蔽しておいた方が得 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MkCodeで直接diffを扱えるようにしてv-code-diffを削除
Why
#17028
Additional info (optional)
Checklist