Skip to content

[0.81] TextInputs are zero height if there is no value and no placeholder text #15730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoates-ms merged 3 commits into from
Mar 6, 2026
Merged

[0.81] TextInputs are zero height if there is no value and no placeholder text #15730

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5149f5d
TextInputs are zero height if there is no value and no placeholder text
acoates-ms Mar 6, 2026
e74fb7a
Change files
acoates-ms Mar 6, 2026
1d7b707
update snapshots
acoates-ms Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-f5511915-0776-4804-894c-ee2485410b96.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "TextInputs are zero height if there is no value and no placeholder text",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions vnext/Microsoft.ReactNative/Fabric/Composition/CompositionViewComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,10 +528,10 @@ facebook::react::RectangleEdges<bool> ComponentView::focusNudges() const noexcep

Assert(m_componentHostingFocusVisual);

if (layoutMetrics.frame.origin.x < 0) {
if (layoutMetrics.frame.origin.x < m_componentHostingFocusVisual->m_layoutMetrics.frame.origin.x) {
nudgeEdges.left = true;
}
if (layoutMetrics.frame.origin.y < 0) {
if (layoutMetrics.frame.origin.y < m_componentHostingFocusVisual->m_layoutMetrics.frame.origin.y) {
nudgeEdges.top = true;
}
if (layoutMetrics.frame.getMaxX() > m_componentHostingFocusVisual->m_layoutMetrics.frame.getMaxX()) {
Expand Down
3 changes: 2 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,7 +1681,8 @@ void WindowsTextInputComponentView::DrawText() noexcept {
}

bool isZeroSized =
m_layoutMetrics.frame.size.width <= (m_layoutMetrics.contentInsets.left + m_layoutMetrics.contentInsets.right);
m_layoutMetrics.frame.size.width <= (m_layoutMetrics.contentInsets.left + m_layoutMetrics.contentInsets.right) ||
m_layoutMetrics.frame.size.height <= (m_layoutMetrics.contentInsets.top + m_layoutMetrics.contentInsets.bottom);
if (!m_drawingSurface || isZeroSized)
return;

Expand Down
4 changes: 3 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputShadowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include <react/featureflags/ReactNativeFeatureFlags.h>
#include <react/renderer/attributedstring/AttributedStringBox.h>
#include <react/renderer/attributedstring/PlaceholderAttributedString.h>
#include <react/renderer/attributedstring/TextAttributes.h>
#include <react/renderer/components/text/BaseTextShadowNode.h>
#include <react/renderer/core/LayoutConstraints.h>
Expand Down Expand Up @@ -185,6 +186,7 @@ AttributedString WindowsTextInputShadowNode::getPlaceholderAttributedString(cons
const auto &props = getConcreteProps();

AttributedString attributedString;
attributedString.setBaseTextAttributes(props.textAttributes);
//[windows
if (!props.placeholder.empty()) {
auto textAttributes = TextAttributes::defaultTextAttributes();
Expand All @@ -203,7 +205,7 @@ AttributedString WindowsTextInputShadowNode::getPlaceholderAttributedString(cons
}
// windows]

return attributedString;
return ensurePlaceholderIfEmpty_DO_NOT_USE(attributedString);
}

#pragma mark - LayoutableShadowNode
Expand Down
Loading