Skip to content

Fix TextInput selection prop #15672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 3 commits into from
Feb 17, 2026
+13 −3
Merged

Fix TextInput selection prop #15672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a755cda
Fix TextInput selection crash and feedback loop
iamAbhi-916 Feb 17, 2026
42d030c
Change files
iamAbhi-916 Feb 17, 2026
c5c0372
add comment for the drawblock defer added
iamAbhi-916 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-b56ee389-667d-4a9b-bc6a-73fa937f57c8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix TextInput selection crash and feedback loop",
"packageName": "react-native-windows",
"email": "74712637+iamAbhi-916@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 6 additions & 3 deletions vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,8 +1225,11 @@ void WindowsTextInputComponentView::updateState(
if (m_mostRecentEventCount == m_state->getData().mostRecentEventCount) {
m_comingFromState = true;
auto &fragments = m_state->getData().attributedStringBox.getValue().getFragments();
UpdateText(fragments.size() ? fragments[0].string : "");

{
// DrawBlock defers DrawText() until after UpdateText completes
DrawBlock db(*this);
UpdateText(fragments.size() ? fragments[0].string : "");
}
m_comingFromState = false;
}
}
Expand Down Expand Up @@ -1375,7 +1378,7 @@ void WindowsTextInputComponentView::EmitOnScrollEvent() noexcept {
}

void WindowsTextInputComponentView::OnSelectionChanged(LONG start, LONG end) noexcept {
if (m_eventEmitter && !m_comingFromState /* && !m_comingFromJS ?? */) {
if (m_eventEmitter && !m_comingFromState && !m_comingFromJS) {
auto emitter = std::static_pointer_cast<const facebook::react::WindowsTextInputEventEmitter>(m_eventEmitter);
facebook::react::WindowsTextInputEventEmitter::OnSelectionChange onSelectionChangeArgs;
onSelectionChangeArgs.selection.start = start;
Expand Down
Loading