pipe: Fix ListenPipe/DialPipe race#125
Merged
lowenna merged 1 commit intomicrosoft:masterfrom Apr 8, 2019
Merged
Conversation
ListenPipe can fail if there is a concurrent DialPipe because there is a race window where DialPipe can connect to the initial server named pipe before it is connected to and closed by ListenPipe. To fix this, use the lower-level NT API for creating the server pipe, since this API allows for specifying that a server pipe should initially be in the disconnected state instead of the listening state. This allows us to avoid the race condition by creating the pipe in the correct state initially, so there is no longer a need to create a dummy client connection.
Contributor
|
Looks scarily good to me. |
lowenna
approved these changes
Apr 8, 2019
Contributor
|
@jterry75 I'll vendor this into hcsshim. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListenPipe can fail if there is a concurrent DialPipe because there is a
race window where DialPipe can connect to the initial server named pipe
before it is connected to and closed by ListenPipe.
To fix this, use the lower-level NT API for creating the server pipe,
since this API allows for specifying that a server pipe should initially
be in the disconnected state instead of the listening state. This allows
us to avoid the race condition by creating the pipe in the correct state
initially, so there is no longer a need to create a dummy client
connection.