Skip to content

FIX/McpWorkbench_errors_properties_and_grace_shutdown#6444

Merged
ekzhu merged 3 commits intomicrosoft:mainfrom
SongChiYoung:FIX/McpWorkbench_errors_properties_and_grace_shutdown
May 2, 2025
Merged

FIX/McpWorkbench_errors_properties_and_grace_shutdown#6444
ekzhu merged 3 commits intomicrosoft:mainfrom
SongChiYoung:FIX/McpWorkbench_errors_properties_and_grace_shutdown

Conversation

@SongChiYoung
Copy link
Copy Markdown
Contributor

Why are these changes needed?

Our McpWorkbench required properties however mongodb-lens's some tools do not has it. I will fix it from when properties is None, -> {}
Our McpWorkbench now does not have stop routine with without async with McpWorkbench(params) as workbench: and lazy init. So, I will adding def del: pass just insert that, It could show error.

Related issue number

Closes #6425

Checks

@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.57%. Comparing base (6fc4f53) to head (71b8f97).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6444      +/-   ##
==========================================
+ Coverage   78.55%   78.57%   +0.02%     
==========================================
  Files         225      225              
  Lines       16523    16525       +2     
==========================================
+ Hits        12979    12984       +5     
+ Misses       3544     3541       -3     
Flag Coverage Δ
unittests 78.57% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu merged commit 880a225 into microsoft:main May 2, 2025
62 checks passed
ChrisBlaa pushed a commit to ChrisBlaa/autogen that referenced this pull request May 8, 2025
## Why are these changes needed?
Our McpWorkbench required properties however mongodb-lens's some tools
do not has it. I will fix it from when properties is None, -> {}
Our McpWorkbench now does not have stop routine with without async with
McpWorkbench(params) as workbench: and lazy init. So, I will adding def
__del__: pass just insert that, It could show error.

## Related issue number

Closes microsoft#6425

## Checks

- [ ] I've included any doc changes needed for
<https://microsoft.github.io/autogen/>. See
<https://github.com/microsoft/autogen/blob/main/CONTRIBUTING.md> to
build and test documentation locally.
- [x] I've added tests (if relevant) corresponding to the changes
introduced in this PR.
- [x] I've made sure all auto checks have passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when Using mcp_server_tools, create_mcp_server_session etc

2 participants