Skip to content

fix: warn when using reflection on tool use with Claude models#5829

Merged
ekzhu merged 3 commits intomainfrom
ekzhu-add-warning
Mar 5, 2025
Merged

fix: warn when using reflection on tool use with Claude models#5829
ekzhu merged 3 commits intomainfrom
ekzhu-add-warning

Conversation

@ekzhu
Copy link
Copy Markdown
Contributor

@ekzhu ekzhu commented Mar 5, 2025

Resolves #5731

@ekzhu ekzhu requested a review from victordibia March 5, 2025 04:11
Copy link
Copy Markdown
Contributor

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (92d857f) to head (07c9201).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/src/autogen_agentchat/agents/_assistant_agent.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5829      +/-   ##
==========================================
- Coverage   75.58%   75.58%   -0.01%     
==========================================
  Files         189      189              
  Lines       12669    12671       +2     
==========================================
+ Hits         9576     9577       +1     
- Misses       3093     3094       +1     
Flag Coverage Δ
unittests 75.58% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu enabled auto-merge (squash) March 5, 2025 04:25
@ekzhu ekzhu merged commit 54c3090 into main Mar 5, 2025
51 checks passed
@ekzhu ekzhu deleted the ekzhu-add-warning branch March 5, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssistantAgent should raise warning when reflection_on_tool_use=True and model family is Claude

2 participants