[Designer] Emit action data in alert message#6456
Merged
paulcam206 merged 7 commits intomainfrom Oct 1, 2021
Merged
Conversation
paulcam206
requested review from
RebeccaAnne,
almedina-ms,
jwoo-msft and
licanhua
|
Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
licanhua
reviewed
Sep 30, 2021
source/nodejs/adaptivecards-designer/src/card-designer-surface.ts
Outdated
Show resolved
Hide resolved
paulcam206
force-pushed
the
paulcam/designer-data-alert
branch
from
569946a to
d39ca84
Compare
licanhua
reviewed
Sep 30, 2021
source/nodejs/adaptivecards-designer/src/card-designer-surface.ts
Outdated
Show resolved
Hide resolved
licanhua
approved these changes
Sep 30, 2021
jwoo-msft
approved these changes
Oct 1, 2021
jwoo-msft
reviewed
Oct 1, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [Designer] Emit action data in alert message Fixes microsoft#6448 * PR feedback * more PR feedback Co-authored-by: Paul Campbell <paulcam@paulcam-mac.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6448
Description
Simple change to the designer's action click handler to emit more information.
Action.OpenUrlAction.SubmitAction.ExecuteHow Verified
Microsoft Reviewers: Open in CodeFlow