Fix TypeError: Derived constructors may only return object or undefined#220
Merged
mbrevda merged 1 commit intombrevda:masterfrom Jan 12, 2019
Merged
Fix TypeError: Derived constructors may only return object or undefined#220mbrevda merged 1 commit intombrevda:masterfrom
mbrevda merged 1 commit intombrevda:masterfrom
Conversation
A class constructor can either return or return an object. If we return true here to exit it will error with `TypeError: Derived constructors may only return object or undefined` during HMR. Removing true, and just return will fix this problem.
Owner
|
Hmm, this a strange bug - thanks for catching and fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A class constructor can either return or return an object. If we return true here to exit it will error with
TypeError: Derived constructors may only return object or undefinedduring HMR.Removing true, and just return will fix this problem.