Skip to content

Add instance state change support via setInstanceOperation API#139

Open
Chr0nicl3 wants to merge 1 commit intodevfrom
ktripath/helixFrontInstanceStateChanges
Open

Add instance state change support via setInstanceOperation API#139
Chr0nicl3 wants to merge 1 commit intodevfrom
ktripath/helixFrontInstanceStateChanges

Conversation

@Chr0nicl3
Copy link
Collaborator

  • Add setInstanceOperation() to InstanceService for ENABLE/DISABLE/EVACUATE with reason and audit trail (instanceOperationSource=USER)
  • Add showInput() to HelperService using InputDialogComponent for collecting reason before state changes
  • Refactor enableInstance/disableInstance to use setInstanceOperation, add evacuateInstance method to InstanceDetailComponent
  • Expand admin menu with Enable/Disable/Evacuate options, each prompting for a reason before executing
  • Add unit tests for setInstanceOperation service method and component

Made-with: Cursor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@Chr0nicl3 Chr0nicl3 force-pushed the ktripath/helixFrontInstanceStateChanges branch from db24ee2 to a95ae9c Compare March 25, 2026 07:14
- Add setInstanceOperation() to InstanceService for ENABLE/DISABLE/EVACUATE
  with reason and audit trail (instanceOperationSource=USER)
- Add showInput() to HelperService using InputDialogComponent for
  collecting reason before state changes
- Refactor enableInstance/disableInstance to use setInstanceOperation,
  add evacuateInstance method to InstanceDetailComponent
- Expand admin menu with Enable/Disable/Evacuate options, each prompting
  for a reason before executing
- Add unit tests for setInstanceOperation service method and component

Made-with: Cursor
@Chr0nicl3 Chr0nicl3 force-pushed the ktripath/helixFrontInstanceStateChanges branch from a95ae9c to 115731e Compare March 25, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant