[GRPO] add chunked grpo streaming over vocab#1160
Open
kashif wants to merge 7 commits intolinkedin:mainfrom
Open
[GRPO] add chunked grpo streaming over vocab#1160kashif wants to merge 7 commits intolinkedin:mainfrom
kashif wants to merge 7 commits intolinkedin:mainfrom
Conversation
Contributor
Author
|
cc @vaibhavjindal for your review |
0e54614 to
e25f787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the chunked GRPO loss to compute only selected-token log-probs by streaming over the vocab dimension. This reduces peak memory for the fused-linear chunked path and preserves the existing high-level fused-linear API.
We also fixes the luspo reduction in the chunked path to match TRL exactly, and tightens the
torch.compileboundary so we only compile the pure loss computation instead of compiling through the closure that callstorch.autograd.grad.So now the two implementations are correctly implementing the trade-offs of their design.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence