mark asset mapper factory service template abstract like the other services#1649
Merged
mark asset mapper factory service template abstract like the other services#1649
Conversation
dbu
commented
Jan 6, 2026
| ]) | ||
| ->tag('liip_imagine.binary.locator', ['shared' => false]); | ||
| $services->set('liip_imagine.binary.locator.asset_mapper', AssetMapperLocator::class) | ||
| ->share(true) |
dbu
commented
Jan 6, 2026
| $services->set('liip_imagine.binary.locator.asset_mapper', AssetMapperLocator::class) | ||
| ->share(true) | ||
| ->public() | ||
| ->abstract() |
dbu
commented
Jan 6, 2026
| ->share(true) | ||
| ->public() | ||
| ->abstract() | ||
| ->private() |
Member
Author
There was a problem hiding this comment.
service should be private, not public
dbu
commented
Jan 6, 2026
| '', // will be injected by AssetMapperLoaderFactory | ||
| ]) | ||
| ->tag('liip_imagine.binary.locator', ['shared' => false]); | ||
| ->tag('liip_imagine.binary.locator', ['shared' => true]); |
Member
Author
There was a problem hiding this comment.
from my understanding, the assetmapper is sort of a singleton, and we have no state, so sharing this service seems fine.
Member
Author
|
@tito10047 can you please check if these changes break nothing with your setup using the asset mapper, and if all changes make sense for you? |
dmaicher
approved these changes
Jan 6, 2026
Contributor
dmaicher
left a comment
dmaicher
left a comment
There was a problem hiding this comment.
Thanks 👍 I can confirm the issue is resolved with those changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #1648 service must be abstract.
Also aligning some other settings like defining it private.