Fix remote branch fetching and revision lookup in update.sh#1235
Merged
botovq merged 1 commit intolibressl:masterfrom Mar 4, 2026
Merged
Fix remote branch fetching and revision lookup in update.sh#1235botovq merged 1 commit intolibressl:masterfrom
botovq merged 1 commit intolibressl:masterfrom
Conversation
This patch changes to: - add `--no-single-branch` to git clone to ensure all remote branches are tracked, allowing the script to switch between OpenBSD versions. - use origin/ prefix for $openbsd_branch to fix revision lookup At initial setup, the branch only exists as a "remote-tracking" reference. Since a local branch hasn't been created yet, git cannot find it by name alone. Adding the origin/ prefix explicitly tells git to look into the remote data we just fetched. This ensures the script can correctly identify the commit hash based on the release timestamp even on a fresh shallow clone. Fix libressl#1233
This was referenced Feb 20, 2026
sergio-nsk
approved these changes
Feb 20, 2026
botovq
approved these changes
Mar 2, 2026
|
Would it maybe make sense to pick this patch to the |
Contributor
Contributor
|
@sjaeckel the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes to:
add
--no-single-branchto git clone to ensure all remote branches are tracked, allowing the script to switch between OpenBSD versions.use
origin/prefix for $openbsd_branch to fix revision lookup At initial setup, the branch only exists as a "remote-tracking" reference. Since a local branch hasn't been created yet, git cannot find it by name alone. Adding the origin/ prefix explicitly tells git to look into the remote data we just fetched.This ensures the script can correctly identify the commit hash based on the release timestamp even on a fresh shallow clone.
Fix #1233