feat: add customization layer for duplicate file functionality#9953
feat: add customization layer for duplicate file functionality#9953jordanrfrazier merged 3 commits intorelease-1.6.0from
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds a new customization hook that re-exports useDuplicateFileV2 and updates a component to import the hook from the customization path instead of the API path. No behavioral changes; only import source and module exposure are adjusted. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.6.0 #9953 +/- ##
=================================================
- Coverage 35.76% 35.75% -0.01%
=================================================
Files 1218 1220 +2
Lines 58134 58150 +16
Branches 5530 5530
=================================================
+ Hits 20793 20794 +1
- Misses 37180 37195 +15
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/frontend/src/customization/hooks/use-custom-duplicate-file.ts (1)
1-3: Use a direct re-export from '@/controllers'Only src/frontend/src/customization/hooks/use-custom-duplicate-file.ts imports the controller path directly; consumers use the customization hook, so the re-export is safe to apply.
Apply this diff:
-import { useDuplicateFileV2 } from "../../controllers/API/queries/file-management/use-duplicate-file"; - -export { useDuplicateFileV2 }; +export { useDuplicateFileV2 } from "@/controllers/API/queries/file-management/use-duplicate-file";
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/frontend/src/customization/hooks/use-custom-duplicate-file.ts(1 hunks)src/frontend/src/modals/fileManagerModal/components/filesContextMenuComponent/index.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/frontend/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/frontend_development.mdc)
src/frontend/src/**/*.{ts,tsx,js,jsx}: All frontend TypeScript and JavaScript code should be located under src/frontend/src/ and organized into components, pages, icons, stores, types, utils, hooks, services, and assets directories as per the specified directory layout.
Use React 18 with TypeScript for all UI components in the frontend.
Format all TypeScript and JavaScript code using the make format_frontend command.
Lint all TypeScript and JavaScript code using the make lint command.
Files:
src/frontend/src/customization/hooks/use-custom-duplicate-file.tssrc/frontend/src/modals/fileManagerModal/components/filesContextMenuComponent/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (41)
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 36/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 31/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 40/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 35/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 33/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 34/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 37/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 38/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 39/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 29/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 32/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 14/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 27/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 21/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 30/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 28/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 25/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 20/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 24/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 23/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 26/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 22/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 13/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 19/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 15/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 18/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 17/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 6/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 16/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 9/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 10/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 4/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 12/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 3/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 7/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 11/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 8/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 2/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 1/40
- GitHub Check: Run Frontend Tests / Playwright Tests - Shard 5/40
- GitHub Check: Test Starter Templates
🔇 Additional comments (1)
src/frontend/src/modals/fileManagerModal/components/filesContextMenuComponent/index.tsx (1)
10-10: LGTM: import now correctly goes through the customization layerKeeps behavior intact while enabling overrides.
- Create use-custom-duplicate-file.ts in customization/hooks - Update import path in filesContextMenuComponent to use customization layer - Maintains original functionality while enabling desktop-specific overrides
cb0af7b to
49a7069
Compare
|
Nightly is broken but all tests passed so adding fast track |
|
* feat: add customization layer for duplicate file functionality - Create use-custom-duplicate-file.ts in customization/hooks - Update import path in filesContextMenuComponent to use customization layer - Maintains original functionality while enabling desktop-specific overrides * bump to run ci in the pr --------- Co-authored-by: Jordan Frazier <122494242+jordanrfrazier@users.noreply.github.com> Co-authored-by: Jordan Frazier <jordan.frazier@datastax.com>
#10127) * feat: add customization layer for duplicate file functionality - Create use-custom-duplicate-file.ts in customization/hooks - Update import path in filesContextMenuComponent to use customization layer - Maintains original functionality while enabling desktop-specific overrides * bump to run ci in the pr --------- Co-authored-by: Ítalo Johnny <italojohnnydosanjos@gmail.com>




Summary by CodeRabbit
Refactor
Chores