Skip to content

ci: wire pre_release input to cross-platform tests#11925

Merged
Adam-Aghili merged 1 commit intomainfrom
fix/cross-platform-pre-release-input
Feb 27, 2026
Merged

ci: wire pre_release input to cross-platform tests#11925
Adam-Aghili merged 1 commit intomainfrom
fix/cross-platform-pre-release-input

Conversation

@vjgit96
Copy link
Collaborator

@vjgit96 vjgit96 commented Feb 26, 2026

Problem

The cross-platform installation tests fail for all platforms during pre-release
runs. The cross-platform-test.yml references
inputs.pre_release in its force-reinstall steps, but:

  1. pre_release is never declared as a workflow_call input in cross-platform-test.yml
  2. release.yml never passes it when calling the workflow

This means inputs.pre_release is always empty → force-reinstall always uses
--no-deps → dependency resolution fails for RC versions.

Fix

  • Add pre_release as a workflow_call boolean input in cross-platform-test.yml
  • Pass pre_release: ${{ inputs.pre_release }} from release.yml

Changes

  • .github/workflows/cross-platform-test.yml — declare pre_release input
  • .github/workflows/release.yml — forward pre_release to cross-platform tests

Summary by CodeRabbit

  • Chores
    • Updated release workflow to support configurable pre-release build handling, enabling improved management of pre-release distributions across platforms.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

Walkthrough

Two GitHub Actions workflow files updated to support pre-release build configuration. A new pre_release boolean input parameter is added to the cross-platform test reusable workflow definition, and the release workflow forwards this parameter when invoking the reusable workflow.

Changes

Cohort / File(s) Summary
Workflow Input Parameter Addition
.github/workflows/cross-platform-test.yml
Added new optional pre_release boolean input parameter (default: false) to the reusable workflow with description "Whether this is a pre-release build".
Parameter Forwarding
.github/workflows/release.yml
Updated Test Cross-Platform Installation reusable workflow call to forward the pre_release input parameter using ${{ inputs.pre_release }}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding and wiring a pre_release input parameter to cross-platform tests across two workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Coverage For New Implementations ✅ Passed Pull request makes changes exclusively to GitHub Actions workflow configuration files, which are CI/CD infrastructure validated through pipeline execution and actionlint static validation rather than traditional unit tests.
Test Quality And Coverage ✅ Passed PR contains only GitHub Actions workflow configuration changes (YAML), no new code implementations requiring test coverage.
Test File Naming And Structure ✅ Passed PR modifies only GitHub Actions workflow files, not test files, so naming and structure check does not apply.
Excessive Mock Usage Warning ✅ Passed PR modifies only GitHub Actions workflow YAML files without any test code or mock usage patterns.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cross-platform-pre-release-input

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2026
@github-actions
Copy link
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 19%
19.03% (6177/32459) 12.53% (3175/25323) 12.75% (888/6962)

Unit Test Results

Tests Skipped Failures Errors Time
2345 0 💤 0 ❌ 0 🔥 30.41s ⏱️

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.51%. Comparing base (9bc50d8) to head (cf39992).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (42.40%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11925      +/-   ##
==========================================
+ Coverage   34.74%   35.51%   +0.77%     
==========================================
  Files        1528     1528              
  Lines       73960    73834     -126     
  Branches    11154    11095      -59     
==========================================
+ Hits        25697    26225     +528     
+ Misses      46826    46178     -648     
+ Partials     1437     1431       -6     
Flag Coverage Δ
backend 55.49% <ø> (+2.77%) ⬆️
lfx 42.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The cross-platform-test.yml references inputs.pre_release in the
force-reinstall steps (added in PR #11322) but never declares it as a
workflow_call input. release.yml also never passes it. This means
inputs.pre_release is always empty, force-reinstall always uses
--no-deps, and dependency resolution fails for RC versions.

- Add pre_release as a workflow_call boolean input in cross-platform-test.yml
- Pass pre_release from release.yml when calling cross-platform-test.yml
@vjgit96 vjgit96 force-pushed the fix/cross-platform-pre-release-input branch from df6081f to cf39992 Compare February 27, 2026 00:52
@vjgit96 vjgit96 enabled auto-merge February 27, 2026 01:07
@Adam-Aghili Adam-Aghili disabled auto-merge February 27, 2026 02:39
@Adam-Aghili Adam-Aghili merged commit 6e95b7c into main Feb 27, 2026
87 of 92 checks passed
@Adam-Aghili Adam-Aghili deleted the fix/cross-platform-pre-release-input branch February 27, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants