ci: wire pre_release input to cross-platform tests#11925
Conversation
WalkthroughTwo GitHub Actions workflow files updated to support pre-release build configuration. A new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (42.40%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11925 +/- ##
==========================================
+ Coverage 34.74% 35.51% +0.77%
==========================================
Files 1528 1528
Lines 73960 73834 -126
Branches 11154 11095 -59
==========================================
+ Hits 25697 26225 +528
+ Misses 46826 46178 -648
+ Partials 1437 1431 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The cross-platform-test.yml references inputs.pre_release in the force-reinstall steps (added in PR #11322) but never declares it as a workflow_call input. release.yml also never passes it. This means inputs.pre_release is always empty, force-reinstall always uses --no-deps, and dependency resolution fails for RC versions. - Add pre_release as a workflow_call boolean input in cross-platform-test.yml - Pass pre_release from release.yml when calling cross-platform-test.yml
df6081f to
cf39992
Compare
Problem
The cross-platform installation tests fail for all platforms during pre-release
runs. The
cross-platform-test.ymlreferencesinputs.pre_releasein its force-reinstall steps, but:pre_releaseis never declared as aworkflow_callinput incross-platform-test.ymlrelease.ymlnever passes it when calling the workflowThis means
inputs.pre_releaseis always empty → force-reinstall always uses--no-deps→ dependency resolution fails for RC versions.Fix
pre_releaseas aworkflow_callboolean input incross-platform-test.ymlpre_release: ${{ inputs.pre_release }}fromrelease.ymlChanges
.github/workflows/cross-platform-test.yml— declarepre_releaseinput.github/workflows/release.yml— forwardpre_releaseto cross-platform testsSummary by CodeRabbit