Skip to content

chore: onnxruntime<=1.23#11889

Merged
Adam-Aghili merged 5 commits intomainfrom
aka/onnxruntime-1.23
Feb 24, 2026
Merged

chore: onnxruntime<=1.23#11889
Adam-Aghili merged 5 commits intomainfrom
aka/onnxruntime-1.23

Conversation

@Adam-Aghili
Copy link
Collaborator

@Adam-Aghili Adam-Aghili commented Feb 24, 2026

onnxruntime<=1.23

Summary by CodeRabbit

  • Chores
    • Updated development dependencies to ensure compatibility with supported versions and improve build stability.

onnxruntime<=1.23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

A dependency version constraint for onnxruntime is added to the dev dependencies section of pyproject.toml, restricting the version to 1.23 or earlier.

Changes

Cohort / File(s) Summary
Development Dependencies
pyproject.toml
Added version constraint onnxruntime<=1.23 to dev dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a constraint for onnxruntime<=1.23 to dev dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Coverage For New Implementations ✅ Passed This PR adds a version constraint to dev dependencies in pyproject.toml, which is a configuration change not requiring test coverage.
Test Quality And Coverage ✅ Passed This PR is a purely administrative dependency constraint change with no new code implementations or functionality, making test quality evaluation criteria not applicable.
Test File Naming And Structure ✅ Passed The custom check about test file naming and structure is not applicable to this PR. The PR only adds a dependency constraint to pyproject.toml without modifying any test files.
Excessive Mock Usage Warning ✅ Passed The custom check for 'Excessive Mock Usage Warning' is not applicable because this PR only modifies pyproject.toml with a dependency constraint and contains no changes to test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aka/onnxruntime-1.23

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 19%
18.8% (6095/32404) 12.25% (3097/25275) 12.64% (879/6952)

Unit Test Results

Tests Skipped Failures Errors Time
2310 0 💤 0 ❌ 0 🔥 32.849s ⏱️

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
pyproject.toml (1)

74-74: Add a lower bound to the onnxruntime constraint.

onnxruntime<=1.23 has no minimum version, meaning uv/pip could resolve to any ancient release (e.g., 0.x). Add a lower bound matching the oldest version actually known to be compatible (likely >=1.16.0 or whatever the tested floor is) to prevent accidental installation of an incompatible old release.

♻️ Suggested improvement
-    "onnxruntime<=1.23"
+    "onnxruntime>=1.16.0,<=1.23"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` at line 74, The onnxruntime version spec in pyproject.toml
currently only sets an upper bound ("onnxruntime<=1.23") which allows very old
incompatible releases; update the constraint to include a tested minimum (for
example change to "onnxruntime>=1.16.0,<=1.23") so pip/uv only resolves to
supported releases—edit the onnxruntime entry in pyproject.toml to add the lower
bound that matches your tested floor.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pyproject.toml`:
- Line 74: The onnxruntime version spec in pyproject.toml currently only sets an
upper bound ("onnxruntime<=1.23") which allows very old incompatible releases;
update the constraint to include a tested minimum (for example change to
"onnxruntime>=1.16.0,<=1.23") so pip/uv only resolves to supported releases—edit
the onnxruntime entry in pyproject.toml to add the lower bound that matches your
tested floor.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb22542 and f80ef8c.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.32%. Comparing base (b9c85d3) to head (7b40d64).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11889      +/-   ##
==========================================
- Coverage   35.47%   35.32%   -0.15%     
==========================================
  Files        1527     1525       -2     
  Lines       73523    73302     -221     
  Branches    11051    11025      -26     
==========================================
- Hits        26081    25893     -188     
+ Misses      46021    45996      -25     
+ Partials     1421     1413       -8     
Flag Coverage Δ
backend 55.82% <ø> (-0.26%) ⬇️
frontend 16.98% <ø> (-0.21%) ⬇️
lfx 42.03% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2026
@Adam-Aghili
Copy link
Collaborator Author

Adam-Aghili commented Feb 24, 2026

@jordanrfrazier changed it to ~= so no chance for weird pipy versions

realized that makes no sense

@Adam-Aghili
Copy link
Collaborator Author

Added a lower bound instead of tilda

@Adam-Aghili Adam-Aghili removed this pull request from the merge queue due to a manual request Feb 24, 2026
@Adam-Aghili Adam-Aghili merged commit 7f9d2a6 into main Feb 24, 2026
166 of 168 checks passed
@Adam-Aghili Adam-Aghili deleted the aka/onnxruntime-1.23 branch February 24, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants