Conversation
onnxruntime<=1.23
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughA dependency version constraint for onnxruntime is added to the dev dependencies section of pyproject.toml, restricting the version to 1.23 or earlier. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
74-74: Add a lower bound to theonnxruntimeconstraint.
onnxruntime<=1.23has no minimum version, meaninguv/pip could resolve to any ancient release (e.g., 0.x). Add a lower bound matching the oldest version actually known to be compatible (likely>=1.16.0or whatever the tested floor is) to prevent accidental installation of an incompatible old release.♻️ Suggested improvement
- "onnxruntime<=1.23" + "onnxruntime>=1.16.0,<=1.23"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 74, The onnxruntime version spec in pyproject.toml currently only sets an upper bound ("onnxruntime<=1.23") which allows very old incompatible releases; update the constraint to include a tested minimum (for example change to "onnxruntime>=1.16.0,<=1.23") so pip/uv only resolves to supported releases—edit the onnxruntime entry in pyproject.toml to add the lower bound that matches your tested floor.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 74: The onnxruntime version spec in pyproject.toml currently only sets an
upper bound ("onnxruntime<=1.23") which allows very old incompatible releases;
update the constraint to include a tested minimum (for example change to
"onnxruntime>=1.16.0,<=1.23") so pip/uv only resolves to supported releases—edit
the onnxruntime entry in pyproject.toml to add the lower bound that matches your
tested floor.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11889 +/- ##
==========================================
- Coverage 35.47% 35.32% -0.15%
==========================================
Files 1527 1525 -2
Lines 73523 73302 -221
Branches 11051 11025 -26
==========================================
- Hits 26081 25893 -188
+ Misses 46021 45996 -25
+ Partials 1421 1413 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
realized that makes no sense |
|
Added a lower bound instead of tilda |
onnxruntime<=1.23
Summary by CodeRabbit