Skip to content

fix: Fix ErrorOutput textarea not filling dialog space#11609

Closed
Cristhianzl wants to merge 2 commits intomainfrom
cz/fix-output-dialog-error
Closed

fix: Fix ErrorOutput textarea not filling dialog space#11609
Cristhianzl wants to merge 2 commits intomainfrom
cz/fix-output-dialog-error

Conversation

@Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Feb 5, 2026

OBJECTIVE: Fix the Component Output dialog where the error textarea collapsed to content height instead of filling the available modal space, caused by Textarea component changes in PR #11183.

CHANGES:

  • Replace generic Textarea component with native textarea in ErrorOutput
  • Add flex container with h-full and flex-1 to fill parent dialog space
  • Set resize-none to prevent manual resizing and maintain full-height layout

Before:
image

After:
image

Summary by CodeRabbit

  • Refactor
    • Simplified error output display component by using native HTML textarea instead of a custom component wrapper. No user-facing functionality or visual changes.

@Cristhianzl Cristhianzl self-assigned this Feb 5, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Walkthrough

A custom Textarea component in the ErrorOutput component is replaced with a native textarea element wrapped in a flex container, with classNames updated to maintain equivalent styling. The component's public API and control flow remain unchanged.

Changes

Cohort / File(s) Summary
Textarea Component Replacement
src/frontend/src/CustomNodes/GenericNode/components/outputModal/components/switchOutputView/components/index.tsx
Replaces custom Textarea component with native textarea element in flex container, updating classNames for borders, padding, and destructive text color styling. Public API signature unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error Bug fix for ErrorOutput component layout issue lacks regression tests despite project convention of co-located tests directories in 302+ test files. Create regression test file at src/frontend/src/CustomNodes/GenericNode/components/outputModal/components/switchOutputView/components/tests/ErrorOutput.test.tsx verifying flex classes, resize-none, readonly attribute, and error message display.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Quality And Coverage ⚠️ Warning Pull request introduces a functional change to ErrorOutput component replacing custom Textarea with native textarea in flex container, but lacks accompanying test coverage for the component rendering, layout classes, or textarea behavior. Create Jest unit test validating textarea rendering with correct attributes and layout classes, and add Playwright test for error output dialog layout in modal.
Test File Naming And Structure ❓ Inconclusive Cannot verify if test files were added or follow correct naming patterns due to inability to access PR file list and repository test structure. Provide the list of files changed in the PR and clarify the testing framework used (Jest, Vitest, etc.) to verify test naming and structure compliance.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the ErrorOutput textarea component to properly fill dialog space by replacing the generic Textarea with a native textarea and flex layout.
Excessive Mock Usage Warning ✅ Passed The pull request only modifies a single UI component file with no corresponding test file changes or additions.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cz/fix-output-dialog-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bug Something isn't working label Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 18%
18.41% (5919/32149) 12.03% (3017/25069) 12.36% (855/6913)

Unit Test Results

Tests Skipped Failures Errors Time
2288 0 💤 0 ❌ 0 🔥 30.731s ⏱️

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.01%. Comparing base (cf4813f) to head (df8f19d).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (41.92%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11609      +/-   ##
==========================================
+ Coverage   34.97%   35.01%   +0.04%     
==========================================
  Files        1515     1515              
  Lines       72569    72508      -61     
  Branches    10935    10923      -12     
==========================================
+ Hits        25379    25390      +11     
+ Misses      45794    45724      -70     
+ Partials     1396     1394       -2     
Flag Coverage Δ
frontend 16.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...l/components/switchOutputView/components/index.tsx 0.00% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2026
@Cristhianzl Cristhianzl enabled auto-merge February 5, 2026 19:52
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 6, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that same problem on successful outputs too

@Cristhianzl Cristhianzl added this pull request to the merge queue Feb 6, 2026
@lucaseduoli lucaseduoli removed this pull request from the merge queue due to a manual request Feb 6, 2026
@lucaseduoli
Copy link
Collaborator

Sorry for removing from merge queue.
This is caused due to a change in the TextArea component itself. It causes errors in other components.
This is fixed in this PR, let me know if it fixes your problem:
#11635

@Cristhianzl Cristhianzl closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants