fix: Fix ErrorOutput textarea not filling dialog space#11609
fix: Fix ErrorOutput textarea not filling dialog space#11609Cristhianzl wants to merge 2 commits intomainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughA custom Textarea component in the ErrorOutput component is replaced with a native textarea element wrapped in a flex container, with classNames updated to maintain equivalent styling. The component's public API and control flow remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 2 warnings, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (41.92%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11609 +/- ##
==========================================
+ Coverage 34.97% 35.01% +0.04%
==========================================
Files 1515 1515
Lines 72569 72508 -61
Branches 10935 10923 -12
==========================================
+ Hits 25379 25390 +11
+ Misses 45794 45724 -70
+ Partials 1396 1394 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I saw that same problem on successful outputs too
|
Sorry for removing from merge queue. |
OBJECTIVE: Fix the Component Output dialog where the error textarea collapsed to content height instead of filling the available modal space, caused by Textarea component changes in PR #11183.
CHANGES:
Before:

After:

Summary by CodeRabbit