feat: add chat-header feature and sliding container #11045
feat: add chat-header feature and sliding container #11045Wallgau merged 31 commits intoplayground-main-forkfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lucaseduoli
left a comment
There was a problem hiding this comment.
Just some code nit picks so that we can maintain a pattern with the existing codebase.
Functionally, the only animations missing are the sessions sidebar when enabling fullscreen, and the Playground button shrinking.
| } | ||
| // Reset after a short delay to allow the select to close | ||
| setTimeout(() => { | ||
| setSelectValue(""); |
There was a problem hiding this comment.
Is this going to be necessary?
| import { useGetAddSessions } from "../../chat-view/chat-header/hooks/use-get-add-sessions"; | ||
| import { useSlidingContainerStore } from "../stores/sliding-container-store"; | ||
|
|
||
| const TRANSITION_MS = 300; |
There was a problem hiding this comment.
We should move this to the constants file
| if (transitionTimer.current) { | ||
| window.clearTimeout(transitionTimer.current); | ||
| } | ||
| transitionTimer.current = window.setTimeout(() => { |
There was a problem hiding this comment.
You should use framer motion transitions instead, so that this doesn't become a problem
| } from "@/components/ui/select-custom"; | ||
| import { cn } from "@/utils/utils"; | ||
|
|
||
| const MENU_ITEM_CLASS = "cursor-pointer px-3 py-2 focus:bg-muted"; |
There was a problem hiding this comment.
You should use a custom class in applies.css instead
| } | ||
|
|
||
| const STROKE_WIDTH = ENABLE_PUBLISH ? 2 : 1.5; | ||
| const ICON_CLASS = "h-4 w-4 transition-all flex-shrink-0"; |
There was a problem hiding this comment.
this should use a custom class as well
| hasIO: boolean; | ||
| } | ||
|
|
||
| const STROKE_WIDTH = ENABLE_PUBLISH ? 2 : 1.5; |
There was a problem hiding this comment.
We can define just one stroke width for both
…ound button to use global playground store and removed stale props; fixed simple-sidebar uncontrolled setOpen to handle function updaters; hardened session rename edit timing; added chat header utilities (session title, session management hooks/components, logs modal, sessions dropdown/sidebar); introduced sliding playground container and supporting hooks/stores/constants/styles; refreshed publish dropdown styling. FlowToolbar now drives playground visibility via usePlaygroundStore (isPlaygroundOpen / setPlaygroundOpen) and tracks analytics off the store state.
07b77b8 to
4be141e
Compare
-Add sliding playground layout (SimpleSidebar + sliding container + store) and toolbar button integration to open it directly.