feat: Make pyo3_arrow::table::Table.append_column support Array#433
feat: Make pyo3_arrow::table::Table.append_column support Array#433kylebarron merged 6 commits intokylebarron:mainfrom
pyo3_arrow::table::Table.append_column support Array#433Conversation
…nd `ArrayReader` as input
bbc3c47 to
1712539
Compare
pyo3_arrow::table::Table.append_column support Arraypyo3_arrow::table::Table.append_column support Array
|
Hmm it passes locally, maybe related to #431? |
kylebarron
left a comment
There was a problem hiding this comment.
This looks great! Thank you! Just a couple comments
|
And yes ideally add_column would also support an array |
|
And yes you can change the |
Soon™ PR.
So if I get this right, I change the local path to pyo3-arrow in this PR, and when you release do you release pyo3-arrow and then in arro3 turn it back on as it is right now? Do we have to do this back and forth between development and releases just for CI to pick up the changes? Or do you manually squash the changes and cherry pick out the path change |
|
I tried to explain this here: https://github.com/kylebarron/arro3/blob/main/DEVELOP.md#updating-pyo3-version During development we can and should use a path dependency. Then any time we update with a new pyo3 version we have to do a dance where we temporarily set the pyo3-arrow version to the git hash. For arro3 releases it's fine to use path dependencies, because they're not getting pushed to crates.io; it's only when we need to ensure all dependencies are using the same pyo3 version. |
kylebarron
left a comment
There was a problem hiding this comment.
That new test looks great
Just one more comment
7128f10 to
6ed33a7
Compare
Fixes #413
Additionally, as you can see in the unit test,
ArrayReaderis also supported, because it already had everything implemented inAnyArray.I haven't touched the change-log since it looks automated to me.
Question: To have a coherent API,
add_columnshould receive the same treatment, wtf?