Make buffers have a length#252
Merged
kylebarron merged 3 commits intokylebarron:mainfrom Oct 30, 2024
Merged
Conversation
Contributor
Author
|
(this is needed by the fsspec integration, although I could work around it in obstore instead; this ought to be done anyway, though) |
kylebarron
approved these changes
Oct 30, 2024
Owner
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
This lgtm. Any reason why it's still in draft?
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
Contributor
Author
|
I had trouble building it locally (need to update a bunch of stuff - I don't normally use poetry), so this was test-by-ci. I thought it was probably simple enough to work. |
Owner
This repo uses |
Owner
|
It just needed the python typing to be updated as well, but now it's good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.