Merged
Conversation
Owner
Author
|
I don't know of a great way to test this on CI, and I'd like to get this into a bug fix ASAP with #232, so I'll merge this. But open to more feedback on the best way to do this! |
Contributor
|
Thank you for looking into it. I will take a look at it later today. 🙂 |
Contributor
|
Hi @kylebarron I have built against the latest changes in I'm not sure if that would work but I guess one way to test this is to have it run in a separate subprocess? We can take inspiration from I can take a look at it. |
Owner
Author
|
If you're able to put up a PR with a test, that would be greatly appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
This is a bit of a hacky implementation, but I'm not sure of another way to do this.
@3ok This seems to work for me, would you be interested in testing this branch?