Skip to content

[KEP-4639] Feature blog 1.33: Image volumes graduate to beta#49984

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
saschagrunert:k8s-1.33-blog-image-volume-beta
Apr 27, 2025
Merged

[KEP-4639] Feature blog 1.33: Image volumes graduate to beta#49984
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
saschagrunert:k8s-1.33-blog-image-volume-beta

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 3, 2025

Description

Blog post about the graduated feature.

Issue

Refers to kubernetes/enhancements#4639

@saschagrunert saschagrunert changed the title Feature blog 1.33: Image volumes graduate to beta WIP: Feature blog 1.33: Image volumes graduate to beta Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2025
@saschagrunert saschagrunert mentioned this pull request Mar 3, 2025
Open
18 tasks
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 3, 2025
@saschagrunert saschagrunert changed the title WIP: Feature blog 1.33: Image volumes graduate to beta WIP: [KEP-4639] Feature blog 1.33: Image volumes graduate to beta Mar 3, 2025
@netlify
Copy link

netlify bot commented Mar 3, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0630c9d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/680b301a3607730008f971d5
😎 Deploy Preview https://deploy-preview-49984--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch from b0c71d5 to 369962d Compare March 13, 2025 08:56
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2025
@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch from 369962d to 15b0361 Compare March 13, 2025 09:07
@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch 4 times, most recently from d6b5f8b to 54790a1 Compare April 7, 2025 08:34
@saschagrunert saschagrunert changed the title WIP: [KEP-4639] Feature blog 1.33: Image volumes graduate to beta [KEP-4639] Feature blog 1.33: Image volumes graduate to beta Apr 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch from 54790a1 to acc3c18 Compare April 7, 2025 08:36
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 7, 2025

Ready for review. PTAL @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 7, 2025
@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch from acc3c18 to 0e077cf Compare April 7, 2025 08:57
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 7, 2025
@haircommander
Copy link
Contributor

haircommander commented Apr 17, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 17, 2025

LGTM label has been added.

DetailsGit tree hash: bd947399fd51cd1b3e0a3743ed25dd9611747cf0

mikebrow
mikebrow reviewed Apr 17, 2025
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reader following might get confused...

quay.io/crio/artifact:v1 ... subpath dir includes content file?

would be easier if the example had an actual directory and an actual file? or is the artifact:v1 actually filled with a dir named dir and a file named file :-) .. checking

regctl image get-file quay.io/crio/artifact:v1 dir/file
1

NVM.. though it is a bit confusing :-)

@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch from aae73ce to 1bbdf14 Compare April 22, 2025 13:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2025
saschagrunert
saschagrunert commented Apr 22, 2025
View reviewed changes
content/en/blog/_posts/2025-05-01-image-volume-beta/index.md
volumes:
- name: volume
image:
reference: quay.io/crio/artifact:v2
Copy link
Member Author

@saschagrunert saschagrunert Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to the v2 image similar to #50581

rytswd
rytswd reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@rytswd rytswd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments added, but otherwise LGTM!

@saschagrunert
Feature blog 1.33: Image volumes graduate to beta
0630c9d 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert force-pushed the k8s-1.33-blog-image-volume-beta branch from 02f5096 to 0630c9d Compare April 25, 2025 06:47
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 25, 2025

Some minor comments added, but otherwise LGTM!

Thank you! I applied the fixes as suggested.

mikebrow
mikebrow approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 25, 2025

LGTM label has been added.

DetailsGit tree hash: 438ab5aa2809429c4ed3f0e9a46cb90fb9e8470c

graz-dev
graz-dev reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece @saschagrunert!
Just added a little suggestion about headings.

content/en/blog/_posts/2025-05-01-image-volume-beta/index.md
for the alpha feature which will be part of the v2.1.0 release and is working on
beta support as part of [PR #11578](https://github.com/containerd/containerd/pull/11578).

### What's new
Copy link
Contributor

@graz-dev graz-dev Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### What's new
## What's new

Maybe you missed it, I suggest to use consistent headings in the content.
If you then use a h2 heading it is not the best option to use an h3 first.

@lmktfy
Copy link
Member

lmktfy commented Apr 27, 2025

/remove-area localization

@k8s-ci-robot k8s-ci-robot removed the area/localization General issues or PRs related to localization label Apr 27, 2025
lmktfy
lmktfy reviewed Apr 27, 2025
View reviewed changes
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to merge as draft.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, mikebrow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8bc524c into kubernetes:main Apr 27, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Reviewer to Done in SIG Node: code and documentation PRs Apr 27, 2025
@saschagrunert saschagrunert deleted the k8s-1.33-blog-image-volume-beta branch April 28, 2025 06:59
sn3hay added a commit to sn3hay/website that referenced this pull request Apr 28, 2025
@sn3hay
KEP-4639: modified for blog publication kubernetes#49984
9bb8fc3 
Updated slug & publish date and removed draft status
@sn3hay sn3hay mentioned this pull request Apr 28, 2025
Merged
@rytswd
Copy link
Member

rytswd commented Apr 29, 2025

Due to another blog not being ready, I'm bumping up this blog to be published today, Tuesday, 29th April, 2025 instead.
#50727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@haircommander haircommander Awaiting requested review from haircommander

+3 more reviewers

@rytswd rytswd rytswd left review comments

@graz-dev graz-dev graz-dev left review comments

@mikebrow mikebrow mikebrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haircommander haircommander

@mikebrow mikebrow

@lmktfy lmktfy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@saschagrunert @lmktfy @haircommander @k8s-ci-robot @rytswd @mikebrow @graz-dev @bart0sh