Fix ILB forwarding rule bug#906
Conversation
Adds cluster subnet to l7 ilb forwarding rule when the cluster network is in custom mode
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
MrHohn
left a comment
MrHohn
left a comment
There was a problem hiding this comment.
Ah, good to know we only need to reference the VM subnet instead of the proxy subnet :)
/approve
/lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@MrHohn Thanks for finding the bug 😄 |
Cherry Pick #906 (Fix ILB forwarding rule bug) to release-1.7
| // IsCustomModeNetwork is a helper for determining if a network is a custom mode network | ||
| // (as opposed to a auto mode network). This is used for l7-ilb since custom mode networks | ||
| // require an additional field on the forwarding rule | ||
| func IsCustomModeNetwork(c *gce.Cloud, networkURL string) (bool, error) { |
There was a problem hiding this comment.
we might want to cache this at some point to avoid doing too many GCE calls
There was a problem hiding this comment.
Good call. Originally this was thought to be the proxy subnet which would change, but now that it's the cluster subnet, we do only need to do it once.
| // Custom mode networks require adding the cluster subnetwork | ||
| if isCustomMode, err := features.IsCustomModeNetwork(l.cloud, l.cloud.NetworkURL()); err != nil { | ||
| return nil, err | ||
| } else if isCustomMode { |
There was a problem hiding this comment.
if you are returning, you don't need the else
4 participants
Adds cluster subnet to l7 ilb forwarding rule when the cluster network is in
custom mode
/assign @MrHohn