Skip to content

Migrating existing front-end namer logic to Legacy#860

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
skmatti:legacy-namer
Oct 21, 2019
Merged

Migrating existing front-end namer logic to Legacy#860
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
skmatti:legacy-namer

Conversation

@skmatti
Copy link
Copy Markdown
Contributor

@skmatti skmatti commented Sep 20, 2019 •
edited
Loading

This is part 3 of V2 Namer: #858.

There is no change in naming policy with this change. But this provides an abstracted front-end namer which internally calls existing naming scheme. This will allow us to extend the frontend namer to migrate to V2 namer seamlessly.

This does not change GC workflow for frontend resources.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 20, 2019

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 20, 2019
@skmatti skmatti mentioned this pull request Sep 20, 2019
Closed
4 tasks
@skmatti
Copy link
Copy Markdown
Contributor Author

skmatti commented Sep 20, 2019

/assign freehan

@freehan
Copy link
Copy Markdown
Contributor

freehan commented Sep 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2019
freehan
freehan reviewed Sep 21, 2019
View reviewed changes
@skmatti skmatti force-pushed the legacy-namer branch 3 times, most recently from 66bf827 to e75fd32 Compare September 25, 2019 01:32
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2019
@skmatti skmatti force-pushed the legacy-namer branch 3 times, most recently from 37c7bfe to 550e9e3 Compare October 1, 2019 17:32
@skmatti skmatti mentioned this pull request Oct 2, 2019
Merged
@skmatti skmatti force-pushed the legacy-namer branch 3 times, most recently from d9a7994 to e34a364 Compare October 3, 2019 17:39
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 3, 2019
@skmatti skmatti force-pushed the legacy-namer branch 3 times, most recently from 234d23a to a6eb853 Compare October 4, 2019 19:05
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 9, 2019
@skmatti skmatti force-pushed the legacy-namer branch 2 times, most recently from 5d88e10 to 6b42a38 Compare October 9, 2019 21:39
freehan
freehan reviewed Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/assign @bowei for approval

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 9, 2019

@freehan: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

LGTM

/assign @bowei for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skmatti skmatti force-pushed the legacy-namer branch 2 times, most recently from 29df662 to fc8ce36 Compare October 11, 2019 18:31
bowei
bowei reviewed Oct 16, 2019
View reviewed changes
@skmatti skmatti force-pushed the legacy-namer branch 7 times, most recently from f4f212d to d6d88df Compare October 16, 2019 21:40
bowei
bowei reviewed Oct 19, 2019
View reviewed changes
bowei
bowei reviewed Oct 19, 2019
View reviewed changes
bowei
bowei reviewed Oct 19, 2019
View reviewed changes
@bowei
Copy link
Copy Markdown
Member

bowei commented Oct 19, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2019
@skmatti skmatti force-pushed the legacy-namer branch 2 times, most recently from a02ba8b to da1eaab Compare October 19, 2019 00:33
@bowei
Copy link
Copy Markdown
Member

bowei commented Oct 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2f2eff4 into kubernetes:master Oct 21, 2019
@skmatti skmatti deleted the legacy-namer branch October 21, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei bowei left review comments

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

+1 more reviewer

@freehan freehan freehan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bowei bowei

@freehan freehan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skmatti @k8s-ci-robot @freehan @bowei