Rebase of #559 "Scaffolding for FrontendConfig"#753
Rebase of #559 "Scaffolding for FrontendConfig"#753k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Conversation
|
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b286566 to
937447f
Compare
|
/lgtm Looks good to me, one comment before merging: Can you merge the two commits "FrontendConfig type skeleton + generated code" & "Regen Frontend Config"? Also, my suggestion would be to separate the L7 ILB stuff into a separate commit. You should be just able to chop the last commit off and open another PR for that one + the actual integration code. |
937447f to
3a1b680
Compare
3a1b680 to
2b87f09
Compare
|
@rramkumar1 done. Mind taking another look? |
|
/ok-to-test |
2b87f09 to
2f37ec4
Compare
2f37ec4 to
e7635b3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rramkumar1, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is primarily a rebase of #559 which updates that PR to the latest state of ingress-gce.
Relevant issues:
#515
#731