Skip to content

Rebase of #559 "Scaffolding for FrontendConfig"#753

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
spencerhance:frontend-config
May 29, 2019
Merged

Rebase of #559 "Scaffolding for FrontendConfig"#753
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
spencerhance:frontend-config

Conversation

@spencerhance
Copy link
Copy Markdown
Contributor

@spencerhance spencerhance commented May 13, 2019

This PR is primarily a rebase of #559 which updates that PR to the latest state of ingress-gce.

Relevant issues:
#515
#731

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and rramkumar1 May 13, 2019 17:43
@spencerhance spencerhance mentioned this pull request May 13, 2019
10 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2019
@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented May 21, 2019

/lgtm
/hold

Looks good to me, one comment before merging: Can you merge the two commits "FrontendConfig type skeleton + generated code" & "Regen Frontend Config"?

Also, my suggestion would be to separate the L7 ILB stuff into a separate commit. You should be just able to chop the last commit off and open another PR for that one + the actual integration code.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2019
@spencerhance spencerhance changed the title Rebase of #559 "Scaffolding for FrontendConfig" + intitial L7-ILB in FrontendConfig Rebase of #559 "Scaffolding for FrontendConfig" May 21, 2019
@spencerhance
Copy link
Copy Markdown
Contributor Author

@rramkumar1 done. Mind taking another look?

@rramkumar1
Copy link
Copy Markdown
Contributor

/ok-to-test
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@rramkumar1
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rramkumar1, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fb195b9 into kubernetes:master May 29, 2019
@spencerhance spencerhance deleted the frontend-config branch May 29, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants