Skip to content

remove loop from flush(). start/stop informers depending on k8s master#580

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
agau4779:master-upgrading
Dec 14, 2018
Merged

remove loop from flush(). start/stop informers depending on k8s master#580
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
agau4779:master-upgrading

Conversation

@agau4779
Copy link
Copy Markdown
Contributor

@agau4779 agau4779 commented Dec 13, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 13, 2018

Hi @agau4779. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 13, 2018
@agau4779
Copy link
Copy Markdown
Contributor Author

agau4779 commented Dec 13, 2018

/assign @rramkumar1

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2018
@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Dec 14, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2018
rramkumar1
rramkumar1 reviewed Dec 14, 2018
View reviewed changes
pkg/e2e/status.go
cmInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
UpdateFunc: func(old, cur interface{}) {
curCm := cur.(*v1.ConfigMap)
upgradeTs := curCm.Data[masterUpgradingKey]
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Don't need this.

pkg/e2e/status.go
sm.cm.Data[key] = string(status)
}

func (sm *StatusManager) setMasterUpgrading(ts string) {
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Don't need this.

Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard comment that we don't need this. We do.

Can we call this updateLocalConfigMap() though? And when you use it, just update the whole config map rather than one key.

rramkumar1
rramkumar1 reviewed Dec 14, 2018
View reviewed changes
cmd/e2e-test/upgrade_test.go Outdated
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want this.

pkg/e2e/sandbox.go Outdated
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want this.

pkg/e2e/status.go Outdated
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this was moved back down? Where it was originally was fine.

@agau4779
Copy link
Copy Markdown
Contributor Author

agau4779 commented Dec 14, 2018

/assign bowei

@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Dec 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agau4779, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 90d4e55 into kubernetes:master Dec 14, 2018
@agau4779 agau4779 deleted the master-upgrading branch February 6, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn

1 more reviewer

@rramkumar1 rramkumar1 rramkumar1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bowei bowei

@rramkumar1 rramkumar1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agau4779 @k8s-ci-robot @rramkumar1 @bowei