Skip to content

Use HTTPS readiness probe for HTTP2 services because the Kubernetes A…#488

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
anuraaga:http2-health-check
Oct 8, 2018
Merged

Use HTTPS readiness probe for HTTP2 services because the Kubernetes A…#488
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
anuraaga:http2-health-check

Conversation

@anuraaga
Copy link
Copy Markdown
Contributor

@anuraaga anuraaga commented Sep 21, 2018

…PI does not make a distinction between HTTPS and HTTP2 for probes.

Fixes #487

Use HTTPS readiness probe for HTTP2 services because the Kubernetes A…
52885cc 
…PI does not make a distinction between HTTPS and HTTP2 for probes.
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2018
@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Oct 2, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2018
@rramkumar1
Copy link
Copy Markdown
Contributor

rramkumar1 commented Oct 2, 2018

/cc @agau4779

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 2, 2018

@rramkumar1: GitHub didn't allow me to request PR reviews from the following users: agau4779.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @agau4779

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anuraaga
Copy link
Copy Markdown
Contributor Author

anuraaga commented Oct 8, 2018

Hello - just checking in. Is there anything blocking this PR? It's a simple bug with a simple fix, so would be good to address sooner than later I think. @agau4779 @rramkumar1

agau4779
agau4779 approved these changes Oct 8, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@agau4779 agau4779 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowei
Copy link
Copy Markdown
Member

bowei commented Oct 8, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anuraaga, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit d6a9498 into kubernetes:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

1 more reviewer

@agau4779 agau4779 agau4779 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bowei bowei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anuraaga @rramkumar1 @k8s-ci-robot @bowei @agau4779