Skip to content

Add server version to echo#314

Merged
nicksardo merged 1 commit intokubernetes:masterfrom
nicksardo:echo-version
Jun 6, 2018
Merged

Add server version to echo#314
nicksardo merged 1 commit intokubernetes:masterfrom
nicksardo:echo-version

Conversation

@nicksardo
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2018
@nicksardo
Copy link
Copy Markdown
Contributor Author

Should we bother with including the commit hash?

@rramkumar1
Copy link
Copy Markdown
Contributor

Not worth it right now, we can always add it if needed.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2018
@nicksardo nicksardo merged commit 8f83638 into kubernetes:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants