Add code for building cluster client and other resources.#236
Merged
nicksardo merged 1 commit intokubernetes:mci-devfrom Apr 20, 2018
Merged
Add code for building cluster client and other resources.#236nicksardo merged 1 commit intokubernetes:mci-devfrom
nicksardo merged 1 commit intokubernetes:mci-devfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
nicksardo
reviewed
Apr 20, 2018
pkg/mci/controller.go
Outdated
Contributor
There was a problem hiding this comment.
go vet fails because these fields are not keyed.
rramkumar1
force-pushed
the
cluster-event-handling
branch
from
5a19fd4 to
4b2517d
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a lot of things:
Note: I will probably add testing for all of this code in a separate PR.
/assign @nicksardo