Add support for Custom Subnet for IPv6 NetLB#2174
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Jun 21, 2023
Merged
Add support for Custom Subnet for IPv6 NetLB#2174k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
panslava
force-pushed
the
netlb-ipv6-customsubnet
branch
3 times, most recently
from
6364eff to
7c64c25
Compare
- Add new annotation networking.gke.io/load-balancer-subnet which adds support to specify custom subnet for external IPv6 forwarding rule - Use new annotation instead of old "networking.gke.io/internal-load-balancer-subnet" for ILB, but fallback to old annotation
panslava
force-pushed
the
netlb-ipv6-customsubnet
branch
from
7c64c25 to
f9197c9
Compare
Contributor
|
lgtm overall please see my comments |
panslava
force-pushed
the
netlb-ipv6-customsubnet
branch
from
89d62dd to
57ccfdc
Compare
panslava
force-pushed
the
netlb-ipv6-customsubnet
branch
from
57ccfdc to
aac550a
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/assign cezarygerard