Skip to content

Add clientsets to gke-diagnoser tool#2022

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ruixiansong:gke-diagnoser-client
Apr 28, 2023
Merged

Add clientsets to gke-diagnoser tool#2022
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ruixiansong:gke-diagnoser-client

Conversation

@ruixiansong
Copy link
Copy Markdown
Contributor

@ruixiansong ruixiansong commented Mar 17, 2023

Add general k8s clientsets
Add BackendConfig clientsets
Add FrontendCondif clientsets

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei March 17, 2023 00:24
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 17, 2023

Hi @songrx1997. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2023
@ruixiansong
Copy link
Copy Markdown
Contributor Author

ruixiansong commented Mar 17, 2023

/assign @swetharepakula
/assign @bowei

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2023
@bowei
Copy link
Copy Markdown
Member

bowei commented Mar 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2023
bowei
bowei reviewed Mar 23, 2023
View reviewed changes
cmd/gke-diagnoser/app/kube/clientset.go Outdated
)

// NewClientSet returns a new Kubernetes clientset
func NewClientSet(kubeContext, kubeConfig string) (*kubernetes.Clientset, error) {
Copy link
Copy Markdown
Member

@bowei bowei Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubeConfig => kubeConfigPath

this is a little confusing kubeConfig is path to the kubeConfig file.

@ruixiansong ruixiansong force-pushed the gke-diagnoser-client branch from 7c05d0e to 13083c8 Compare March 29, 2023 20:06
swetharepakula
swetharepakula reviewed Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: songrx1997, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 09b5657 into kubernetes:master Apr 28, 2023
@ruixiansong ruixiansong deleted the gke-diagnoser-client branch May 2, 2023 19:33
This was referenced Jul 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei bowei left review comments

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@bowei bowei

@swetharepakula swetharepakula

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ruixiansong @k8s-ci-robot @bowei @swetharepakula