Process IPv6 Endpoints #2012
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Mar 17, 2023
Merged
Conversation
* leftover from removing endpoints support
* L4 supports IPv6 single stack services and needs the IPv6 endpoints to determine the right nodes to add to the NEG. * L7 does not support IPv6 addresses yet, and should skip processing those endpoints
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Member
Author
Contributor
|
thank you @swetharepakula ! good job I verified on my cluster, and l4 ILB ipv6 singlestack etp local is working code looks fine as well I can give lgtm, or you want someone else to also take a look? |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: panslava, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 18, 2023
[Cherry-pick #2012 to 1.22] Process all endpoints and allow endpoint calculators to filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the logic of skipping IPv6 endpoints to the individual endpoint calculators. This allows L4 to use the ipv6 endpoints and l7 to ignore them.