Updating FakeLoadBalancers.Delete to return NotFound when appropriate#178
Merged
nicksardo merged 1 commit intokubernetes:masterfrom Mar 28, 2018
Merged
Updating FakeLoadBalancers.Delete to return NotFound when appropriate#178nicksardo merged 1 commit intokubernetes:masterfrom
nicksardo merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
size/S
nikhiljindal
force-pushed
the
fakesDelete
branch
from
ccb13e3 to
4557106
Compare
Contributor
Author
|
Updated to fix the tests |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref GoogleCloudPlatform/k8s-multicluster-ingress#155
Fakes should return NotFound as the real code does.
This will help us catch issues like GoogleCloudPlatform/k8s-multicluster-ingress#155 in our unit tests.
cc @G-Harmon @nicksardo @bowei @MrHohn