Skip to content

Cleanup some unused files#150

Merged
nicksardo merged 1 commit intokubernetes:masterfrom
rramkumar1:cleanup
Mar 14, 2018
Merged

Cleanup some unused files#150
nicksardo merged 1 commit intokubernetes:masterfrom
rramkumar1:cleanup

Conversation

@rramkumar1
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 commented Mar 14, 2018

This PR removes:

  1. tests/manifests - Not being used
  2. rc.yaml, ingress-app.yaml - We have sufficient examples in examples/ so these do not need to exist anymore.

/assign @nicksardo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2018
@nicksardo nicksardo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@nicksardo nicksardo merged commit 1cc610d into kubernetes:master Mar 14, 2018
@cceckman
Copy link
Copy Markdown

Please revert this change, or provide an appropriate pointer from the instructions to examples. README.md still refers to rc.yaml and ingress-app.yaml.

@rramkumar1
Copy link
Copy Markdown
Contributor Author

@cceckman Sorry bout that. Working on a fix.

@rramkumar1 rramkumar1 mentioned this pull request Jul 12, 2018
@rramkumar1
Copy link
Copy Markdown
Contributor Author

@cceckman #394 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants