Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
G-Harmon
reviewed
Oct 11, 2017
| @@ -1,18 +1,44 @@ | |||
| all: push | |||
| # Copyright 2016 The Kubernetes Authors. | |||
Member
Author
|
@G-Harmon you have the power...to make pull requests :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look at the commits for review. The Makefile and rules.mk are from kube-dns and support a clean build environment with multi architectures.
The standard k8s projects have been following is to put library code in pkg/