Skip to content

Fix backendconfig annotation key for beta#1030

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
skmatti:be-config-e2e-fix
Feb 20, 2020
Merged

Fix backendconfig annotation key for beta#1030
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
skmatti:be-config-e2e-fix

Conversation

@skmatti
Copy link
Copy Markdown
Contributor

@skmatti skmatti commented Feb 20, 2020

/assign @freehan
cc: @spencerhance

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 20, 2020

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2020
spencerhance
spencerhance approved these changes Feb 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@freehan
Copy link
Copy Markdown
Contributor

freehan commented Feb 20, 2020

/lgtm
/approve

Probably need to understand what is the follow up to flip it to GA for some versions.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2020
@freehan
Copy link
Copy Markdown
Contributor

freehan commented Feb 20, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2020
@freehan
Copy link
Copy Markdown
Contributor

freehan commented Feb 20, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 490cb4b into kubernetes:master Feb 20, 2020
@skmatti skmatti deleted the be-config-e2e-fix branch February 24, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@spencerhance spencerhance spencerhance approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@freehan freehan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skmatti @k8s-ci-robot @freehan @spencerhance