Skip to content

Fixed Broken Links#680

Open
yashasvimisra2798 wants to merge 6 commits intokubernetes:masterfrom
yashasvimisra2798:fixbrokenlinks
Open

Fixed Broken Links#680
yashasvimisra2798 wants to merge 6 commits intokubernetes:masterfrom
yashasvimisra2798:fixbrokenlinks

Conversation

@yashasvimisra2798
Copy link
Contributor

Fixes #679

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2026
@k8s-ci-robot k8s-ci-robot requested a review from palnabarun March 11, 2026 18:41
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yashasvimisra2798
Once this PR has been reviewed and has the lgtm label, please assign lmktfy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from reylejano March 11, 2026 18:41
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2026
@yashasvimisra2798 yashasvimisra2798 changed the title Fixed Broken Links in 01-starting-out.md Fixed Broken Links Mar 11, 2026
@TineoC
Copy link
Contributor

TineoC commented Mar 12, 2026

Could you detail the links that weren't working for you? https://www.kubernetes.dev/docs/guide/ In the source code is using relative paths as they are being ingested in the https://github.com/kubernetes/contributor-site/blob/master/hack/gen-content.sh script

@yashasvimisra2798
Copy link
Contributor Author

@TineoC please check the issue #679 I have listed the broken links there.

@TineoC
Copy link
Contributor

TineoC commented Mar 12, 2026

From this page, the values and code of conduct pages are working fine.

Getting Started | Kubernetes Contributors https://share.google/bY6YSZvbr8AZXhe4G

@jberkus
Copy link
Contributor

jberkus commented Mar 13, 2026

@yashasvimisra2798 you have not listed the broken links in #679. Please do. Also, note that it's our policy to use relative links where possible; it saves us cleanup when we move a page.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2026
Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more information about which links are broken. Many of these appear fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Broken Links

4 participants