Add OCI Volume Source support to crictl [create|run] --with-pull#1464
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jul 17, 2024
Merged
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
7084ef2 to
17764a1
Compare
18 tasks
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
17764a1 to
d8fdb7a
Compare
k8s-ci-robot
removed
the
needs-rebase
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
3 times, most recently
from
2019afc to
50a59f0
Compare
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
50a59f0 to
8516ef8
Compare
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
2 times, most recently
from
53ff5e2 to
d55497b
Compare
k8s-ci-robot
added
the
needs-rebase
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
2 times, most recently
from
48abdd5 to
eca281c
Compare
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
869f7f9 to
fc6c9b1
Compare
k8s-ci-robot
removed
the
needs-rebase
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
saschagrunert
changed the title
crictl [create|run] --with-pull
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
fc6c9b1 to
adec55d
Compare
Member
|
/approve |
Contributor
|
@kwilczynski: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cmd/crictl/container.go
Outdated
| } | ||
|
|
||
| for _, image := range images { | ||
| logrus.Infof("Pulling image: %s", image) |
Contributor
There was a problem hiding this comment.
can this message be a bit clearer that it's being pulled for a mount? also: maybe we should only do this if the pull-on-create flag is set?
Member
Author
There was a problem hiding this comment.
I changed the log messages to reflect which image / OCI object we'd like to pull on which purpose.
I'm not sure to which flag you're referring. Right now it's only enabled when --with-pull is specified on create or run.
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
adec55d to
ab2421d
Compare
Member
|
New changes look good! /approve |
Contributor
|
@kwilczynski: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
saschagrunert
changed the title
crictl [create|run] --with-pullcrictl [create|run] --with-pull
saschagrunert
changed the title
crictl [create|run] --with-pullcrictl [create|run] --with-pull
k8s-ci-robot
added
the
do-not-merge/work-in-progress
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
ab2421d to
c1daf41
Compare
k8s-ci-robot
added
size/S
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
oci-volumesource-cri-tools
branch
from
c1daf41 to
bd276bf
Compare
saschagrunert
changed the title
crictl [create|run] --with-pullcrictl [create|run] --with-pull
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
Member
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding support for the new OCI Volume Source feature.
Which issue(s) this PR fixes:
Refers to kubernetes/enhancements#4639
Special notes for your reviewer:
Requires kubernetes/kubernetes#125659
Does this PR introduce a user-facing change?