Merged
Conversation
On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
This was referenced Apr 14, 2025
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 3f3d3ffcaba9d0ced6c31db9ef231a97a671848a |
mjudeikis
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs go mod deps with kcp-dev/kcp/sdk.
The
github.com/kcp-dev/kcp/sdk v0.0.0-00010101000000-000000000000require directive is a bit fishy, also in the original go.mod file -- is this a remnant of some leftoverreplacethat has been removed? I kept it around because I too needed to replace that module, specifically to pull in kcp-dev/kcp#3377.This should be merged (and tagged) before kcp-dev/kcp#3377.
Part of: kcp-dev/kcp#3375