Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes compatibility with ruby-head where OpenSSL::PKey::RSA.new can no longer be called without parameters. The changes replace instance-based method checks with class-level method checks.
- Replaced
.new.respond_to?(:method_name)with.method_defined?(:method_name)to check for method existence without instantiation - Updated version to 3.1.3 and added changelog entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/jwt/jwk/rsa_spec.rb | Updated test skip conditions to use method_defined? instead of instantiating RSA objects |
| lib/jwt/jwk/rsa.rb | Updated production code alias condition to check method existence without instantiation |
| lib/jwt/version.rb | Bumped TINY version from 2 to 3 for patch release |
| CHANGELOG.md | Added v3.1.3 changelog entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The spec against ruby-head is failing currently. Seems like it's not allowed to call
.newwithout params anymore.Should not cause trouble with production setups as we check for openssl before looking at the RSA capabilities.
Checklist
Before the PR can be merged be sure the following are checked: