Fix key base equality and spaceship operators#569
Merged
Conversation
Contributor
Author
|
FYI I followed some of the recommendations here: https://shopify.engineering/implementing-equality-in-ruby |
anakinj
approved these changes
Oct 14, 2023
Member
|
Thank you for taking time fixing this. Would you have the time to add a changelog entry for this into the changelog file. I had forgotten to update it after the last release, fixed now on main so if you rebase your branch you should have a place to add an entry. |
a945343 to
82b0fc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue when trying to use
Rails.cache.fetch.Specifically there is a fallback condition that tried to compare:
@value == true(where@valuewas a JWK)and this gem raised an error:
I haven't run into the spaceship operator issue, but I figured it is similar enough to fix at the same time.