Skip to content

rspec 3 breaks passing tests#44

Merged
progrium merged 3 commits intojwt:masterfrom
zshannon:rspec-3
Sep 9, 2014
Merged

rspec 3 breaks passing tests#44
progrium merged 3 commits intojwt:masterfrom
zshannon:rspec-3

Conversation

@zshannon
Copy link

@zshannon zshannon commented Sep 9, 2014

To reproduce, install rspec 3.0+ and run rake test. It will produce 3 failures where be_true and be_false are used when rspec 3 expects be_truthy and be_falsey.

We can:

  1. lock the gem version to 2+ (as I have in this PR), or,
  2. update the tests to support version 3+, which I'm happy to do on this PR if that's the preferred resolution.

@progrium
Copy link
Contributor

progrium commented Sep 9, 2014

Supporting version 3 to keep it fresh would be great!

@zshannon
Copy link
Author

zshannon commented Sep 9, 2014

@progrium all set.

progrium added a commit that referenced this pull request Sep 9, 2014
rspec 3 breaks passing tests
@progrium progrium merged commit 34b3f39 into jwt:master Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants